Step1 - GitHub(데이터 레이어) #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namjackson
approved these changes
Sep 22, 2024
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| internal data class RemoteGitHubRepoInfo( |
There was a problem hiding this comment.
Remote라는 단어를 이용해서 Remote 모델을 분리하셨네요 👍
저는 응답을 의미하는 Response라는 접미사를 붙이곤합니다 :)
Comment on lines
+7
to
+9
| internal interface GetGitHubRepositoryUseCase { | ||
| suspend operator fun invoke(organization: String): List<UiGitHubRepoInfo> | ||
| } |
There was a problem hiding this comment.
도메인 레이어 분리 👍
UseCase를 인터페이스로 분리한 이유가 무엇인가요? :)
| @@ -0,0 +1,6 @@ | |||
| package nextstep.github.ui.model | |||
|
|
|||
| data class UiGitHubRepoInfo( | |||
There was a problem hiding this comment.
Ui모델을 분리해주셨네요 👍
Ui를 접두어로 붙이는 스타일이시군요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님.
많이 늦었지만 가능하시다면 리뷰 부탁드립니다.
4단계 Step1 요구사항 구현입니다.